I had passed the phone screen for a chance to work as a ClojureScript developer for a startup in manhattan, and they emailed me a coding challenge. Basically, they wanted me to make a glorified do-to list using reagent and re-frame. This post is to document the feedback from the reviewer of my code and think out loud about what he / she meant by it and what I can do to avoid the same issues the future.
I wanted to pass along some constructive feedback on your Derpframe code exercise. Here are a few (hopefully helpful bits of feedback):
Hope that is helpful to you.
If I want to be serious about professionally developing Reagent / Re-Frame applications I should really have a good editor with solid code reformatting tools and use a Clojure linter. Never ever type (nth item 1) with a hardcoded 1 again! Also, try to use get-in instead of nested gets right from the beginning instead of having to refactor them in a commit after the one being looked at by the person judging your code. ;) Stay strong, bend over, and take all the criticism you can get because these are the things that will make you wiser. You'll encounter plenty of "No"s on the the road to greatness. Just try to learn as much as you can along the way.
If you're curious, the code for my project is hosted here.
The posts on this site are written and maintained by Jim Lynch. About Jim...